Add section targeting tests for ratelimit policy #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: averevki <[email protected]>
averevki
force-pushed
the
ratelimit_section_tests
branch
from
f96cd8e to
05da8e7
Compare
This was referenced Feb 17, 2025
azgabur
reviewed
Mar 6, 2025
| @pytest.fixture(scope="module") | ||
| def rate_limit(cluster, blame, module_label, gateway): | ||
| """Add a RateLimitPolicy targeting the specific Gateway Listener""" | ||
| rlp = RateLimitPolicy.create_instance(cluster, blame("limit"), gateway, "api", labels={"testRun": module_label}) |
There was a problem hiding this comment.
Please use GatewayListener.name if referencing the default name for listener api
| def rate_limit(cluster, blame, module_label, route): | ||
| """Add a RateLimitPolicy targeting the first HTTPRoute Rule""" | ||
| rate_limit = RateLimitPolicy.create_instance( | ||
| cluster, blame("limit"), route, "rule-1", labels={"testRun": module_label} |
There was a problem hiding this comment.
How does the route know about rule-1 and rule-2 section names?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refined #600 PR from @martinhesko
Closes #561