Add slow_loadbalancers and refactor MockserverBackend #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Zgabur <[email protected]>
azgabur
force-pushed
the
refactor-mockserver
branch
from
e9bba6c to
5b6380d
Compare
trepel
reviewed
Mar 6, 2025
| lambda obj: "ip" in self.service.refresh().model.status.loadBalancer.ingress[0], timelimit=timeout | ||
| ) | ||
| assert success, f"Service {self.name} did not get ready in time" | ||
| def wait_for_ready(self, timeout=60 * 5): |
There was a problem hiding this comment.
where do you actually call this method? I can see that you removed the self.deployment.wait_for_ready() call (was on line 26) and moved it into this method but I am struggling to see where this method is actually used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying testing on ROSA I noticed tests failing from loadbalancers not being ready due to them being attached to service but not yet started in AWS. I have maybe not a nice solution but I dont have any better idea to just add sleep in wait_for_ready in Gateway and Service methods. I put a toggle in settings.yaml in which this can be enabled as this happens only on AWS and it is pointless to have such long wait in other scenarios.
Additionally I refactored MockserverBackend to be better + factor out the hardcoded mockserver image.