Skip to content

Change simple dns strategy test case in more DNS way #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azgabur
Copy link
Contributor

@azgabur azgabur commented May 22, 2025

To test "Simple strategy" we do not really need to check the round-robin way of returned DNS responses. In the description of AWS route 53 Simple strategy it is stated that they return the responses at random. The standard DNS behavior when multiple A records exist for single name is to return the order in round-robin or random fashion. In ideal world how this test is currently written we would want to expect this behavior. But due to caching, recursive resolver different implementation, system dns implementation or the randomness we cant always guarantee this behavior to be exact.

Checking that in the response are all A records that are expected and not bothering with their orders seems to me as better and more durable testing scenario with less false fails while trusting that the DNS provider or recursive resolver provider or any other places where it makes a difference, to return the order of records at random.

@azgabur azgabur requested a review from averevki May 22, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant