Updating Dev testing env #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsnaps
reviewed
Oct 24, 2024
utils/deploy/envoy.yaml
Outdated
| @@ -337,7 +337,7 @@ data: | |||
| "data": [ | |||
| { | |||
| "selector": { | |||
| "selector": "filter_state.wasm\\.kuadrant\\.identity\\.userid", | |||
| "selector": "auth.identity.userid", | |||
There was a problem hiding this comment.
This is probably not something one would ever want to do.
All selector usages should be avoided. This should be an expression here.
didierofrivia
force-pushed
the
dev-testing-env
branch
from
10e70f2
to
5eb0b5a
Compare
Signed-off-by: dd di cesare <[email protected]>
Signed-off-by: dd di cesare <[email protected]>
Signed-off-by: dd di cesare <[email protected]>
Signed-off-by: dd di cesare <[email protected]>
didierofrivia
force-pushed
the
dev-testing-env
branch
from
5eb0b5a
to
1f8f580
Compare
alexsnaps
reviewed
Oct 24, 2024
| @@ -212,7 +204,7 @@ data: | |||
| "scope": "rlp-ns-B/rlp-name-B", | |||
| "data": [ | |||
| { | |||
| "static": { | |||
| "expression": { | |||
| "key": "rlp-ns-B/rlp-name-B/limit-not-to-be-activated", | |||
| "value": "1" | |||
There was a problem hiding this comment.
While this would work, this also changed the type tho! It's now int(1) ... but will be erased and will be 1, just as if you had it as "\"1\"" in there, which would be closer semantically to what this was before...
tl;dr not wrong, but... ;)
eguzki
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our development environment for testing and the e2e test for the remote address using CEL expressions and predicates.