Err out better when failing to eval CEL #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Snaps <[email protected]>
alexsnaps
commented
Nov 7, 2024
| @@ -55,7 +55,7 @@ impl Expression { | |||
| Self::new_expression(expression, true) | |||
| } | |||
|
|
|||
| pub fn eval(&self) -> Value { | |||
| pub fn eval(&self) -> Result<Value, String> { | |||
There was a problem hiding this comment.
This is the only real change really...
alexsnaps
commented
Nov 7, 2024
| .all(|(pos, predicate)| match predicate.test() { | ||
| Ok(b) => b, | ||
| Err(err) => { | ||
| error!("Failed to evaluate {}: {}", self.predicates[pos], err); |
There was a problem hiding this comment.
... and these are the real things that I wanted...
| _ => panic!("Only scalar values can be sent as data"), | ||
| }, | ||
| Err(err) => { | ||
| error!("Failed to evaluate {}: {}", cel.value, err); |
| Err(err) => { | ||
| error!( | ||
| "Failed to evaluate {}: {}", | ||
| self.route_rule_conditions.predicates[pos], err |
eguzki
approved these changes
Nov 7, 2024
adam-cattermole
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.