-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration development environment #67
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
13357796 | Triggered | Generic High Entropy Secret | 8dd4c97 | utils/deploy/authconfig.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
envoy.yaml: | | ||
static_resources: | ||
clusters: | ||
- name: authorino_wasm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this cluster is named authorino
I am unable to reach it from within the shim so for now it is named authorino_wasm
- todo: investigate why this is the case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had a chance to figure this one out yet, still somewhat curious but I don't think it's urgent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
- Documentation is needed
- I like the docker-compose environment, looks like more lightweight and quicker to work with. However, with authorino, due to it's complexity, and being a k8s controller, docker-compose is no longer an option. Should we keep both environments? any thoughts on this?
- role: control-plane | ||
image: kindest/node:v1.30.0 | ||
extraMounts: | ||
- hostPath: $(WASM_PATH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is a template, which is rendered with the right wasm path. This adds some (minor) extra complexity.
Have you considered volume source being a secret which could be easier to manage and monitor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea was to reduce the number of changes required to iterate as developing - so a simple rebuild using make build
has generated a new file in the kind cluster (it still needs reloading so a make local-rollout
is also needed).
That being said it's still pretty simple to re-create the secret each time we rebuild so I'm not tied to one approach or the other. If you prefer the secret I can look into it
@eguzki agreed, will look to add all the docs on using this.
I was also unsure on this one - I agree docker-compose is a good lightweight alternative for limitador only, but then again two different dev environments might have differences which make it hard to spot issues. I think that whether we remove the docker-compose or not I'll leave it to a future PR outside of this one though. |
0a2886c
to
59ae77b
Compare
ed8eec1
to
6c9343d
Compare
59ae77b
to
faa4830
Compare
722f149
to
dacfcdc
Compare
faa4830
to
1ca22ff
Compare
37b6f1d
to
312710e
Compare
@adam-cattermole The PR includes some commits not related to the integration development environment. Not sure that is intended or not. Regarding the integration development environment, I think it needs few more iterations, but we can polish it in following up PR's. LGTM. |
@eguzki Oh you're right, it's diverged from base branch, let me rebase again |
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
1ca22ff
to
cb74375
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆒
Added new make commands to:
TLS_ENABLED
To deploy all of the above:
Cleanup:
To test changes to the wasm binary you can simply run the following to redeploy in the cluster:
To watch the envoy + wasm logs:
To test the API:
curl -H "Host: test.a.auth.com" http://127.0.0.1:8000/get -i
curl -H "Host: test.a.rlp.com" http://127.0.0.1:8000/get -i
curl -H "Host: test.b.rlp.com" http://127.0.0.1:8000/get -i