-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new bindings for MobEffectInstance binding #955
base: main
Are you sure you want to change the base?
Conversation
okay, just fixed the title |
yeah but why |
you can just bind it with Java.loadClass() |
???? |
okay, there we go |
okay, now that MobEffects is deleted from bindings, and updated the script |
renaming the binding for your MobEffectUtils class with the alias "MobEffectInstance" will be highly confusing |
reanme it to "MobEffectUtil" in the binding? |
yea |
Add the info tags to the methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing, we now have infinite effect durations, a helper (or two or three) should be added for those.
Description
In my mod, when registering a thing, you can add a list of effects to it. I did not want to add bindings to the
MobEffects
and to make aMobEffectInstance
.This PR adds two new bindings to create a
MobEffectInstance
, and also to fetch effects fromMobEffects
.I'm not sure of
MobEffects
is already a binding, but well, added it sinse I could not find it..I added a binding for the
MobEffectInstance
for most of the constructors.Example Script
Using
MobEffects.CONFUSION
for example (nausia)Other details
This adds two new bindings so I would not need to do it with my mod, and would just be built into KubeJS.
Feel free to make changes.