Outputing the function counter to XML. #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giulianobelinassi
force-pushed
the
functions_counter
branch
from
59fe7d9 to
d1ed4d4
Compare
|
Now, globalFunctions tag appears in the header of the xml output file.
For now, globalFunctions = totalGlobalFunctions, and has 'tfg' as short label. Signed-off-by: Lucas Kanashiro <[email protected]> Signed-off-by: Giuliano Belinassi <[email protected]>
lucaskanashiro
force-pushed
the
functions_counter
branch
from
d1ed4d4 to
764b95a
Compare
After changing globalFunctions to totalGlobalFunctions some tests broke. Signed-off-by: Lucas Kanashiro <[email protected]> Signed-off-by: Giuliano Belinassi <[email protected]>
|
Almost done... |
Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Giuliano Belinassi <[email protected]>
|
Done. Check spec/language/ruby/global_test/metrics |
|
Almost done, can you just rebase your branch with dev and fix the conflicts? |
Signed-off-by: giulianobelinassi <[email protected]> Signed-off-by: Lucas Kanashiro <[email protected]> Signed-off-by: Bruno Sesso <[email protected]>
|
We do not know why the build is failing, but all tests succeed in my machine. @rodrigosiqueira Could you run it locally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, globalFunctions tag appears in the header of the xml output file.