Pre parser comments #235
Closed
Pre parser comments #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Bernardo Amorim <[email protected]>
Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Bernardo Amorim <[email protected]>
Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Bernardo Amorim <[email protected]>
Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Bernardo Amorim <[email protected]>
Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Bernardo Amorim <[email protected]>
Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Bernardo Amorim <[email protected]>
Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Bernardo Amorim <[email protected]>
Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Bernardo Amorim <[email protected]> Signed-off-by: Lucas Kanashiro <[email protected]> Signed-off-by: Giuliano Belinassi <[email protected]>
Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Bernardo Amorim <[email protected]> Signed-off-by: Lucas Kanashiro <[email protected]> Signed-off-by: Giuliano Belinassi <[email protected]>
Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Bernardo Amorim <[email protected]> Signed-off-by: Lucas Kanashiro <[email protected]> Signed-off-by: Giuliano Belinassi <[email protected]>
Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Bernardo Amorim <[email protected]> Signed-off-by: Lucas Kanashiro <[email protected]> Signed-off-by: Giuliano Belinassi <[email protected]>
We handle one line comments. Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Lucas Kanashiro <[email protected]>
…eparser data structure Because we now take the multi-line comments out of the text that will be analysed by analyse_first_step some tests crashed and we didn't fix it Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Giuliano Belinassi <[email protected]>
…comments out of the received code Multiple line comments are now added to the preparser datastructure. And because of that it removes the comments passed to the analyse_first_step method on language.rb. In the future the datastructured will be entirely passed to the analyse_first_step, but this is not implemented yet. Signed-off-by: Bruno Sesso <[email protected]> Signed-off-by: Giuliano Belinassi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added features for the pre parser added on #231
We added support for one and multiple line comments, such as:
It also removes the supported comments from the code passed to the analyse_first_step method