-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NodeBundle] Undo deleting pages #2706
Open
JZuidema
wants to merge
20
commits into
Kunstmaan:master
Choose a base branch
from
e-sites:feature/undelete-nodes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4402bf0
feature/undelete-nodes
JZuidema 0f70f5c
feature/undelete-nodes
JZuidema 631ddf3
feature/undelete-nodes
JZuidema dab4e8f
feature/undelete-nodes
JZuidema e1eed18
feature/undelete-nodes
JZuidema c7b8ae5
Merge branch 'master' into feature/undelete-nodes
JZuidema ca06327
feature/undelete-nodes
JZuidema bca8eb2
feature/undelete-nodes
JZuidema 6b67689
feature/undelete-nodes
JZuidema e576798
feature/undelete-nodes
JZuidema 4391b9f
feature/undelete-nodes
JZuidema 602924a
feature/undelete-nodes
JZuidema a51b83a
Fix invalid use
JZuidema d12fa0d
Set deleted parameter
JZuidema 1a35997
Update src/Kunstmaan/NodeBundle/Controller/NodeAdminController.php
JZuidema d59d195
Configure enabling undo deleting nodes
JZuidema 9eee63e
Merge remote-tracking branch 'origin/feature/undelete-nodes' into fea…
JZuidema 05a812b
Merge branch 'master' into feature/undelete-nodes
JZuidema ed19196
Return when node is not deleted
JZuidema d379ffb
Fix style
JZuidema File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
35 changes: 35 additions & 0 deletions
35
src/Kunstmaan/NodeBundle/AdminList/DeletedNodeAdminListConfigurator.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
<?php | ||
|
||
namespace Kunstmaan\NodeBundle\AdminList; | ||
|
||
use Doctrine\ORM\QueryBuilder; | ||
use Kunstmaan\AdminListBundle\AdminList\FilterType\ORM\DateFilterType; | ||
use Kunstmaan\AdminListBundle\AdminList\FilterType\ORM\StringFilterType; | ||
|
||
class DeletedNodeAdminListConfigurator extends NodeAdminListConfigurator | ||
{ | ||
public function buildFilters() | ||
{ | ||
$this | ||
->addFilter('title', new StringFilterType('title'), 'kuma_node.admin.list.filter.title') | ||
->addFilter('created', new DateFilterType('created'), 'kuma_node.admin.list.filter.created_at') | ||
->addFilter('updated', new DateFilterType('updated'), 'kuma_node.admin.list.filter.updated_at') | ||
; | ||
} | ||
|
||
public function buildFields() | ||
{ | ||
$this | ||
->addField('title', 'kuma_node.admin.list.header.title', true, '@KunstmaanNode/Admin/title.html.twig') | ||
->addField('created', 'kuma_node.admin.list.header.created_at', true) | ||
->addField('updated', 'kuma_node.admin.list.header.updated_at', true) | ||
; | ||
} | ||
|
||
public function adaptQueryBuilder(QueryBuilder $queryBuilder) | ||
{ | ||
parent::adaptQueryBuilder($queryBuilder); | ||
|
||
$queryBuilder->setParameter('deleted', 1); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a early return here if the node is not deleted. A possible case could be that you delete a parent with nested children and already restore a child before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've applied this