Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#1181 fixed. Added age calculator project with the required changes #1296

Closed

Conversation

ParnaRoyChowdhury777
Copy link

Have you read the Contributing Guidelines ?

Yes

Description

I have added the Age Calculator Project under the Basic section of Web Development and have done the changes you mentioned previously.

Fixes #1181

Checklist

  • I've read the contribution guidelines.
  • I've checked the issue list before deciding what to submit.
  • I've edited the README.md and link to my code.

Related Issues or Pull Requests

Fixes Issue #1181
Corrects the previous PR #1251

Copy link

@ParnaRoyChowdhury777

It's great having you contribute to this project

Thank you for opening a Pull Request 🙌 , Welcome to Project Guidance 💖 We will review everything and get back to you :)

@github-actions github-actions bot requested a review from Kushal997-das July 12, 2024 13:37
@ParnaRoyChowdhury777
Copy link
Author

@Kushal997-das I closed the previous one...

Copy link
Owner

@Kushal997-das Kushal997-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ParnaRoyChowdhury777. Please make the following updates:

  1. Remove sections like 'Contributing' and 'Contact' from your readme.md file.

  2. Pull the latest updates from the repository.

  3. Address the issue in your readme.md file as described here.

  4. Additionally, include instructions prompting users to enter their age for better clarity.

dd

@Kushal997-das Kushal997-das added Changes-required Little bit changes required . gssoc This level is for GSSOC level1 Under level 1 labels Jul 19, 2024
@ParnaRoyChowdhury777
Copy link
Author

@Kushal997-das check once

Copy link
Owner

@Kushal997-das Kushal997-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ParnaRoyChowdhury777,


We still have a couple of issues:

  1. There are elements out of place. Please refer to the image below for details.

not fix

  1. Clicking age calculator redirects to another project. Please correct this without altering previous configurations, or we will have to close the PR.

@Kushal997-das Kushal997-das added No_Update It's been so long you are not responding to this issue so we are going to close the issue soon. and removed Changes-required Little bit changes required . level1 Under level 1 labels Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This level is for GSSOC No_Update It's been so long you are not responding to this issue so we are going to close the issue soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title: Add an Age calculator under medium section of Web Development. I want to contribute under GSSOC' 24.
2 participants