feature: 선생님 회원가입 추가 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
학교 가져오는부분 다시보니까 너무 하드 코딩되어 있어서 리팩터링 해도 괜찮을까? @sominyun |
- model - repository - service - reader - validator - appender - exception
sominyun
approved these changes
May 6, 2024
There was a problem hiding this comment.
batch 리팩토링 한 거 깔끔하고 보기 좋당~~~~~
근데 나 궁금한게 있는데 이게 소셜 로그인은
socialLogin -> input: accessToken, output: accessToken,refreshToken
인데 선생님 로그인은
Login ->input: 아이디, 비밀번호 -> output: accessToken
이잖아
이게 소셜로그인은 프론트에서 accessToken을 넘겨 주고 우리가 refreshToken을 만들어서 주는 거고
선생님로그인은 프론트에서 아이디랑 비밀번호를 넘겨주면 우리가 accessToken을 만들어서 주고 refreshToken은 사용하지 않는 방식인거야?
|
|
||
| fun loginTeacher(request: LoginTeacher.Request): LoginTeacher.Response{ | ||
| val (username, password) = request.convertLoginInfo(passwordEncoder::encode) | ||
| val teacher = teacherReader.findByUsernameAndPassword(username, password) |
There was a problem hiding this comment.
궁금한게 이거 만약에 유저네임이랑패스워드 없으면 그냥 null 반환되면 예외처리가 어떻게 되는거야???? 그냥 500뜨는거야?
| val (username, password) = request.convertLoginInfo(passwordEncoder::encode) | ||
| val teacher = teacherReader.findByUsernameAndPassword(username, password) | ||
| return LoginTeacher.Response( | ||
| accessToken = jwtProvider.generateTeacherAccessToken(Claims.TeacherClaims(teacher.id)), |
There was a problem hiding this comment.
Suggested change
| accessToken = jwtProvider.generateTeacherAccessToken(Claims.TeacherClaims(teacher.id)), | |
| accessToken = jwtProvider.generateTeacherAccessToken(Claims.TeacherClaims(teacher.id)) |
진짜 별거 아닐수도 있는데 저 , 필요없는거겠지..?
There was a problem hiding this comment.
오 이참에 우리 lint도 설정해둘까
|
일단은 선생님의 경우 그렇게 크게 중요한 부분이 아닌것같아서 우선 access token만 반환하도록 만들어뒀어 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗃 Issue
🔥 Task
📄 Reference