학급 open api batch로 가져오기 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlarbals824
reviewed
May 7, 2024
| if (!hasNext) { | ||
| endIndex = schoolRepository.count().toInt() | ||
| } | ||
| val schools = schoolRepository.findAll().subList(startIndex, endIndex) |
There was a problem hiding this comment.
findall()보다는 page나 커서기반으로 조회하자
모든 데이터를 다 조회하면 성능이 매우 안좋을것같아
There was a problem hiding this comment.
page로 가져오면 다음 데이터가 있는지 hasNext 프로퍼티가 있어서 위에 hasNext 구하기 위한 쿼리는 없애자
There was a problem hiding this comment.
굿굿 이런 리뷰 조타
page 단위로 조회하는걸로 수정완
커서랑 페이징 중에 페이징이 메모리 적게 쓴다길래 페이징으로 해봤는데 별로면 말해줘~
| .retrieve() | ||
| .bodyToMono(String::class.java) | ||
| .map { | ||
| jacksonObjectMapper().readValue(it, ClassroomOpenApiResponse::class.java) |
There was a problem hiding this comment.
이 부분도 spring objectmapper 사용하자
tlarbals824
reviewed
May 7, 2024
| val schools = schoolRepository.findAll(pageable) | ||
| val hasNext = schools.hasNext() | ||
| val classroomInfoList: MutableList<ClassroomInfoProvider.ClassroomInfo> = mutableListOf() | ||
| schools.forEach { school -> |
There was a problem hiding this comment.
이 부분 forEach보다는 map을 사용해서 바로 List<ClassroomInfoProvider.ClassroomInfo>로 바꾸는거는 어때
| val ORD_SC_NM: String?, | ||
| val DDDEP_NM: String?, | ||
| val CLASS_NM: String, | ||
| val LOAD_DTM: String? |
| @Query("SELECT s.schoolCode FROM School s WHERE s.schoolCode IN :schoolCodes") | ||
| fun findSchoolCodeBySchoolCodeIn(schoolCodes: List<String>): List<String> | ||
|
|
||
| override fun findAll(pageable: Pageable): Page<School> |
There was a problem hiding this comment.
기본으로 제공되는 메소드여서 override 안해도 될것같아
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗃 Issue
🔥 Task
📄 Reference