Skip to content

Commit

Permalink
Required updates for conda builds (#61)
Browse files Browse the repository at this point in the history
* update to jupyter_client requirement to be more flexible owing to incompatibilities with newer notebooks installs

* update conda version being used on backend

* test removal of support for python 3.5

* Update to README to reflect removal of Python 3.5 support, addition of update to kdb retreival to allow new retrieval location

* addition of build agreement in conda_build.bat

Co-authored-by: Conor McCarthy <[email protected]>
  • Loading branch information
cmccarthy1 and Conor McCarthy authored Dec 17, 2020
1 parent d9beca6 commit 66d94b0
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,12 @@ Jupyter kernel for kdb+. Features include
## Requirements

- kdb+ ≥ v3.5 64-bit
- Python ≥ 3.5
- Python ≥ 3.6
- [embedPy](https://github.com/KxSystems/embedPy)

**Note:**

As of September 5, 2020. Python 3.5 has reached end of life as indicated [here](https://www.python.org/downloads/release/python-3510/). As such official support for this Python Version has been removed in favour of updates to support Python 3.8.

## Overview

Expand Down
1 change: 1 addition & 0 deletions build/conda_build.bat
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ rmdir /S /Q C:\projects\jupyterq\q\
call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" x86_amd64
conda install -y "conda-build" || goto :error
conda install -y anaconda-client conda || goto :error
conda update -y --all || goto :error
:: set up requirements from requirements.txt
python -c "print('|'.join([line.strip('\n')for line in open('requirements.txt')]))" > reqs.txt
set /P JUPYTERQ_REQS=<reqs.txt
Expand Down
2 changes: 1 addition & 1 deletion build/getkdb.bat
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
curl -fsSOJL %W64%
curl -fsSJL %W64%
mkdir q
7z x w64.zip -oq
echo|set /P =%QLIC_KC% >q\kc.lic.enc
Expand Down
1 change: 0 additions & 1 deletion conda-recipe/conda_build_config.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
python:
- 3.5 [unix]
- 3.6
- 3.7
- 3.8
2 changes: 1 addition & 1 deletion tests/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
pytest
jupyter_kernel_test
jupyter_client==5.2.3
jupyter_client>=5.2.3

0 comments on commit 66d94b0

Please sign in to comment.