Skip to content

Commit

Permalink
KXI-30038: Testing new naming convention
Browse files Browse the repository at this point in the history
  • Loading branch information
cterry45 committed Oct 23, 2023
1 parent b81258c commit 1eefb6f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/prod_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ jobs:
needs: app-sec
runs-on: ubuntu-latest
steps:
- name: Set Tag Var
id: vars
run: |
VERSION=${{ github.ref_name }}
echo "run_tag=$(echo ${VERSION:1})" >> $GITHUB_OUTPUT
- name: Checkout code
uses: actions/checkout@v2
with:
Expand Down Expand Up @@ -101,8 +106,8 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: kdb-${{ github.ref_name }}.vsix
asset_name: kdb-${{ github.ref_name }}.vsix
asset_path: kdb-${steps.vars.outputs.run_tag}.vsix
asset_name: kdb-${steps.vars.outputs.run_tag}.vsix
asset_content_type: application/octet-stream

# manual-approve:
Expand Down
2 changes: 1 addition & 1 deletion release_process.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ On each push to Main or Dev there is a vsix built and uploaded to [Downloads Por

1. Update the [package.json](package.json) to bump the version for the extension. This is important because when installing the package (VSIX), it's important to have the updated version to ensure VSCode does not install another version. This applies after the extension is published to the marketplace. This uses semantic version of build.release.patch (e.g., 0.1.8)

2. Update the [CHANGELOG.md](CHANGELOG.md) to include the release version the the appropriate comments on updates.
2. Update the [CHANGELOG.md](CHANGELOG.md) to include the release version the the appropriate comments on updates. This uses semantic version of build.release.patch (e.g., v0.1.8)

3. Merge the changes

Expand Down

0 comments on commit 1eefb6f

Please sign in to comment.