Skip to content

Commit

Permalink
remove slice times
Browse files Browse the repository at this point in the history
  • Loading branch information
Philip-Carneiro-KX committed Mar 5, 2024
1 parent 4b93cc3 commit 39c8987
Showing 1 changed file with 4 additions and 34 deletions.
38 changes: 4 additions & 34 deletions src/webview/components/kdbDataSourceView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ export class KdbDataSourceView extends LitElement {
@state() declare filled: boolean;
@state() declare temporality: string;
@state() declare temporal: boolean;
@state() declare sliceStartTS: string;
@state() declare sliceEndTS: string;
@state() declare filters: Filter[];
@state() declare labels: Label[];
@state() declare sorts: Sort[];
Expand All @@ -82,8 +80,6 @@ export class KdbDataSourceView extends LitElement {
this.filled = false;
this.temporality = "";
this.temporal = false;
this.sliceStartTS = "";
this.sliceEndTS = "";
this.filters = [createFilter()];
this.labels = [createLabel()];
this.sorts = [createSort()];
Expand Down Expand Up @@ -131,8 +127,6 @@ export class KdbDataSourceView extends LitElement {
if (optional) {
this.filled = optional.filled;
this.temporal = optional.temporal;
this.sliceStartTS = optional.startTS;
this.sliceEndTS = optional.endTS;
this.filters = optional.filters;
this.labels = optional.labels;
this.sorts = optional.sorts;
Expand Down Expand Up @@ -163,8 +157,6 @@ export class KdbDataSourceView extends LitElement {
optional: {

Check failure on line 157 in src/webview/components/kdbDataSourceView.ts

View workflow job for this annotation

GitHub Actions / test (macos-latest)

Type '{ filled: boolean; temporal: boolean; filters: Filter[]; labels: Label[]; sorts: Sort[]; aggs: Agg[]; groups: Group[]; }' is missing the following properties from type '{ filled: boolean; temporal: boolean; startTS: string; endTS: string; filters: Filter[]; labels: Label[]; sorts: Sort[]; aggs: Agg[]; groups: Group[]; }': startTS, endTS

Check failure on line 157 in src/webview/components/kdbDataSourceView.ts

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest)

Type '{ filled: boolean; temporal: boolean; filters: Filter[]; labels: Label[]; sorts: Sort[]; aggs: Agg[]; groups: Group[]; }' is missing the following properties from type '{ filled: boolean; temporal: boolean; startTS: string; endTS: string; filters: Filter[]; labels: Label[]; sorts: Sort[]; aggs: Agg[]; groups: Group[]; }': startTS, endTS
filled: this.filled,
temporal: this.temporal,
startTS: this.sliceStartTS,
endTS: this.sliceEndTS,
filters: this.filters,
labels: this.labels,
sorts: this.sorts,
Expand Down Expand Up @@ -223,7 +215,7 @@ export class KdbDataSourceView extends LitElement {
if (this.isInsights && this.isMetaLoaded) {
return this.insightsMeta.api
.filter(
(api) => api.api === ".kxi.getData" //|| !api.api.startsWith(".kxi.")
(api) => api.api === ".kxi.getData", //|| !api.api.startsWith(".kxi.")
)
.map((api) => {
const value =
Expand Down Expand Up @@ -338,7 +330,7 @@ export class KdbDataSourceView extends LitElement {
value="${operator}"
?selected="${operator === filter.operator}"
>${operator}</vscode-option
>`
>`,
)}
</vscode-dropdown>
</div>
Expand Down Expand Up @@ -559,7 +551,7 @@ export class KdbDataSourceView extends LitElement {
value="${operator}"
?selected="${operator === agg.operator}"
>${operator}</vscode-option
>`
>`,
)}
</vscode-dropdown>
</div>
Expand Down Expand Up @@ -832,28 +824,6 @@ export class KdbDataSourceView extends LitElement {
>
</vscode-dropdown>
</div>
<vscode-text-field
type="time"
class="text-field"
value="${this.sliceStartTS}"
@input="${(event: Event) =>
(this.sliceStartTS = (
event.target as HTMLSelectElement
).value)}"
?hidden="${this.temporality !== "slice"}"
>Start Time</vscode-text-field
>
<vscode-text-field
type="time"
class="text-field"
value="${this.sliceEndTS}"
@input="${(event: Event) =>
(this.sliceEndTS = (
event.target as HTMLSelectElement
).value)}"
?hidden="${this.temporality !== "slice"}"
>End Time</vscode-text-field
>
</div>
<div class="col">
Expand Down Expand Up @@ -887,7 +857,7 @@ export class KdbDataSourceView extends LitElement {
event.target as HTMLSelectElement
).value)}">
${this.renderTargetOptions(
this.qsqlTarget
this.qsqlTarget,
)}</vscode-dropdown
>
</div>
Expand Down

0 comments on commit 39c8987

Please sign in to comment.