Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artifact path #122

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Fix artifact path #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50e2a31
Update sonar-project.properties
nfarrell-kx Sep 20, 2023
7518fc9
Update release.yml
nfarrell-kx Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,20 @@ jobs:
- name: Build VSIX file
run: yarn run build
- name: Run Tests
run: xvfb-run -a yarn run test
run: xvfb-run -a yarn run coverage
- name: Packaging
run: yarn run package
- name: Upload artifact
uses: actions/upload-artifact@v3
with:
name: KDB-VSCode-Extension
path: ./kdb-*vsix
- name: Upload lcov result for app-sec job
uses: actions/upload-artifact@v3
with:
name: lcov
path: coverage-reports/lcov.info
retention-days: 1

app-sec:
runs-on: ubuntu-latest
Expand All @@ -52,6 +58,11 @@ jobs:
- name: Install dependencies
run: yarn install

- name: Download lcov result from test job
uses: actions/download-artifact@v3
with:
name: lcov

- name: SonarCloud Scan
uses: sonarsource/sonarqube-scan-action@master
env:
Expand Down
2 changes: 1 addition & 1 deletion sonar-project.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
sonar.projectKey=kxvscode
sonar.sources=.
sonar.javascript.lcov.reportPaths=coverage-reports/lcov.info
sonar.javascript.lcov.reportPaths=lcov.info