Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KXI-33084: Insights remote connections; KXI-33419: User switching; KXI-33420: Failed login #229

Merged
merged 9 commits into from
Jan 17, 2024
Merged

KXI-33084: Insights remote connections; KXI-33419: User switching; KXI-33420: Failed login #229

merged 9 commits into from
Jan 17, 2024

Conversation

ecmel
Copy link
Collaborator

@ecmel ecmel commented Jan 16, 2024

Changes introduced by this PR

Fixes the following related with insights connections:

  • KXI-33084: Support Remote (& WSL) Environment connections for Insights login flow
  • KXI-33419: No way to switch to a different user
  • KXI-33420: Can't try again after failed login

@ecmel ecmel marked this pull request as ready for review January 16, 2024 12:49
@kx-sonarqube
Copy link

kx-sonarqube bot commented Jan 17, 2024

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
87.1% 87.1% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ecmel ecmel merged commit 2335cd6 into dev Jan 17, 2024
5 checks passed
@ecmel ecmel deleted the ecmel-ssh branch January 17, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philip-Carneiro-KX Philip-Carneiro-KX Philip-Carneiro-KX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecmel @Philip-Carneiro-KX