KXI-33125: Enable publish to marketplace in prod release #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfarrell-kx
reviewed
Jan 25, 2024
package.json
Outdated
| @@ -657,7 +657,8 @@ | |||
| "test": "tsc -p ./test && node ./out/test/runTest.js", | |||
| "coverage": "tsc -p ./test && node ./out/test/runTest.js --coverage", | |||
| "package": "npx vsce package", | |||
| "format": "prettier --ignore-path .gitignore --write \"**/*.+(js|ts|json)\"" | |||
| "format": "prettier --ignore-path .gitignore --write \"**/*.+(js|ts|json)\"", | |||
| "publish": "npx vsce publish --yarn" | |||
There was a problem hiding this comment.
Do we want the --yarn option here? We're using npm elsewhere
There was a problem hiding this comment.
I just followed the documentation with that, you're right ill remove it and do a dummy release
cterry45
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
nfarrell-kx
approved these changes
Jan 29, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced by this PR