[LS] KXI-36337, KXI-36622, KXI-36758, KXI-36708, KXI-36571 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
88.5% Coverage on New Code
0.0% Duplication on New Code
|
for: KXI-36337, still happening with functions
|
|
for the KXI-36708 still not working
|
Philip-Carneiro-KX
requested changes
Mar 5, 2024
36708 is about “This param was declared, then never used” it is fixed, the new hint is true it is not used as ordinary variable. Regarding KXI-36337 with the current setup there is no straight forward way to distinguish qdoc from ordinary commands and it is useful for documentation purposes. |
Philip-Carneiro-KX
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced by this PR