Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KXI-38280 - Refactoring Insights connections service #277

Merged
merged 19 commits into from
Apr 24, 2024
Merged

KXI-38280 - Refactoring Insights connections service #277

merged 19 commits into from
Apr 24, 2024

Conversation

Philip-Carneiro-KX
Copy link
Collaborator

Changes introduced by this PR

  • Multiple connections for insights
  • fully integration to multiple connections with local q and insights
  • new icons, tooltips for state of connection
  • new class for insights connection

@Philip-Carneiro-KX Philip-Carneiro-KX self-assigned this Apr 22, 2024
@Philip-Carneiro-KX Philip-Carneiro-KX changed the base branch from main to dev April 22, 2024 13:05
@kx-sonarqube
Copy link

kx-sonarqube bot commented Apr 24, 2024

Quality Gate passed Quality Gate passed

The SonarQube Quality Gate passed, but some issues were introduced.

27 New issues
0 Security Hotspots
82.1% 82.1% Coverage on New Code
0.6% 0.6% Duplication on New Code

See analysis details on SonarQube

@Philip-Carneiro-KX Philip-Carneiro-KX merged commit 8f02a72 into dev Apr 24, 2024
5 checks passed
@Philip-Carneiro-KX Philip-Carneiro-KX deleted the KXI-38280 branch April 24, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecmel ecmel ecmel approved these changes

@nfarrell-kx nfarrell-kx Awaiting requested review from nfarrell-kx

Assignees

@Philip-Carneiro-KX Philip-Carneiro-KX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Philip-Carneiro-KX @ecmel