Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hashflowv3 #26

Merged
merged 2 commits into from
Oct 3, 2023
Merged

add hashflowv3 #26

merged 2 commits into from
Oct 3, 2023

Conversation

ngocthanh1389
Copy link
Member

No description provided.

Haiss2
Haiss2 reviewed Oct 3, 2023
View reviewed changes
cmd/tradelogs/main.go
@@ -95,6 +96,7 @@ func run(c *cli.Context) error {
"hashflow": hashflow.MustNewParser(),
"native": native.MustNewParser(),
"kyberswaprfq": kyberswaprfq.MustNewParser(),
"hashflowv3": hashflowv3.MustNewParser(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it after line 83 too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ngocthanh1389 ngocthanh1389 requested a review from Haiss2 October 3, 2023 08:55
Haiss2
Haiss2 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@Haiss2 Haiss2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngocthanh1389 ngocthanh1389 merged commit 45eb616 into main Oct 3, 2023
5 checks passed
@ngocthanh1389 ngocthanh1389 deleted the hashflowv3 branch October 3, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haiss2 Haiss2 Haiss2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngocthanh1389 @Haiss2