feat: build pathfinding lib #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1up1n
force-pushed
the
pathfinding-algorithm
branch
from
f778514 to
297be78
Compare
hiepnv90
reviewed
Aug 8, 2025
hiepnv90
reviewed
Aug 8, 2025
hiepnv90
reviewed
Aug 11, 2025
hiepnv90
reviewed
Aug 19, 2025
| } | ||
|
|
||
| scale := math.Pow10(int(decimals)) | ||
| minUnits := int64(math.Ceil((minThresholdUsd / price) * scale)) |
There was a problem hiding this comment.
This can be very big (can greater than max int64). I think should use the normal way to split amount.
- Convert input amount into usd
- Calculate number of splits by divide input amount in usd to minThresholdUSD
- Pick the smaller amount between input numSplits and calculated numSplits.
| numSplits uint64, | ||
| minThresholdUSD float64, | ||
| ) *entity.Hop { | ||
| if len(pools) == 0 || amountIn.Sign() <= 0 || numSplits == 0 { |
| continue | ||
| } | ||
|
|
||
| isolatedPools := isolated.NewIsolatedPools(pools) |
There was a problem hiding this comment.
Why need to create new isolatedPools each time generate new path?
| func (f *Finder) FindBestPathsOptimized( | ||
| params *entity.FinderParams, | ||
| minHops map[string]uint64, | ||
| edges map[string]map[string][]dexlibPool.IPoolSimulator, |
There was a problem hiding this comment.
We need to maintains pools' state across multiple find paths run, so can use technique like pathfinder-lib currently use (SimulationBucket).
There was a problem hiding this comment.
Also, need to take care for swap limits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.