Skip to content

Commit

Permalink
Merge pull request #341 from gleonSun/kycalcite-1.30.0.x-Debug
Browse files Browse the repository at this point in the history
KE-11534 [Follow up]Remove the if operator check
  • Loading branch information
gleonSun authored Mar 20, 2024
2 parents fe103e6 + 2d37796 commit 31a6a2f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,11 @@ private SqlLibraryOperators() {
}),
SqlFunctionCategory.SYSTEM) {
@Override public boolean validRexOperands(int count, Litmus litmus) {
// Calcite 1.30 changed the if operator to case when,
// which causes Kylin computable columns to be unusable
return true;
// IF is translated to RexNode by expanding to CASE.
return litmus.fail("not a rex operator");
// return litmus.fail("not a rex operator");
}
};

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ systemProp.org.gradle.internal.publish.checksums.insecure=true
# This is version for Calcite itself
# Note: it should not include "-SNAPSHOT" as it is automatically added by build.gradle.kts
# Release version can be generated by using -Prelease or -Prc=<int> arguments
calcite.version=1.30.0-kylin-4.x-r03
calcite.version=1.30.0-kylin-4.x-r04
# This is a version to be used from Maven repository. It can be overridden by localAvatica below
calcite.avatica.version=1.20.0

Expand Down

0 comments on commit 31a6a2f

Please sign in to comment.