refocus: don't leave the snippet if the active node is an exitNode (fix #1112). #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L3MON4D3
changed the title
L3MON4D3
force-pushed
the
fix_manual_enter_leave
branch
from
f04183d
to
b781873
Compare
L3MON4D3
force-pushed
the
fix_manual_enter_leave
branch
from
1709f8a
to
1a6043b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the node active within a snippet is an exitNode the leave-callback has already been called, and we should not trigger it again.
I think this should work, doing it as a PR since I want to add tests.