Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filetypes instead of langs from treesitter #1175

Merged
merged 6 commits into from
May 17, 2024

Conversation

leiserfg
Copy link
Contributor

No description provided.

@L3MON4D3
Copy link
Owner

Oh cool, I'd worried about having to hardcode something like this!
I'm a bit unsure about 1. get_filetypes returns a list, so return { ..get_filetypes(..)} seems wrong, and 2. I don't know about availability (wrt nvim-version) of get_filetypes, could you make sure it's only called when available (vim.F.if_nil should work splendidly)

@leiserfg
Copy link
Contributor Author

leiserfg commented May 16, 2024

Sure, we could fallback to 'lang' if missing, regarding returning the file types, I'm not sure if we should if should join them with '.' or keep only the first

Edit: Kids, don't comment in GitHub while drunk.

@L3MON4D3
Copy link
Owner

Yeaah that's the stuff 👌 :D

@L3MON4D3 L3MON4D3 merged commit 03c607c into L3MON4D3:master May 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants