Update README.md #1265
Merged
Update README.md #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to make clear it's needed a 'package.json' file with proper content in order to require("luasnip.loaders.from_vscode").lazy_load({ paths = { "./my-cool-snippets" } }) to work.
I think the way this section is written right now may lead the reader to think package.json may be just a config file that can be added later on. Personally, it took me too much time to figure out this (imho) detail. This necessity wasn't entirely clear for me even after reading the documentation. Only after testing it by making the file and put the required content on it.
Hope this 2¢ may help other anxious people like me to set their cool snippets up. Thank you.
|
Hey, thank you for the addition, if it would've helped you it will surely help others :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to make clear it's needed a 'package.json' file with proper content in order to require("luasnip.loaders.from_vscode").lazy_load({ paths = { "./my-cool-snippets" } }) to work.
I think the way this section is written right now may lead the reader to think package.json may be just a config file that can be added later on. Personally, it took me too much time to figure out this (imho) detail. This necessity wasn't entirely clear for me even after reading the documentation. I know "vscode: any directory in runtimepath that contains a package.json contributing snippets." is clear enough, sure. But, idk. I had to read this 3 times to realize I didn't had this file in my snippets folder.
Hope this 2¢ may help other anxious people like me to set their cool snippets up. This is just a suggestion, please change it if you like. Thank you.