Get cash import by date Entity Framework rewrite #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add SSMiniTransaction entity * Stub test * Improve setup * SSmini DB setup * Working test case * Pull out duplicate data gen * Unneeded warning suppression * Format * Cleanup * Check for suspense transactions * Cleanup * format * Rename * Extract var * Remove brackets
adamtry
changed the title
adamtry
changed the title
adamtry
requested review from
FaisalHackney,
Duslerke and
a team
as code owners
adamtry
changed the title
adamtry
commented
Aug 8, 2024
| @@ -39,7 +39,7 @@ dotnet_naming_symbols.public_symbols.applicable_accessibilities = public | |||
|
|
|||
| #Parameters should be camel case | |||
| dotnet_naming_style.camel_case_style.capitalization = camel_case | |||
| dotnet_naming_rule.local_objects_must_be_camel_case.severity = error | |||
| dotnet_naming_rule.local_objects_must_be_camel_case.severity = suggestion | |||
There was a problem hiding this comment.
We consistently don't follow this rule, so it just gets in the way
| @@ -136,3 +136,6 @@ dotnet_diagnostic.CA1001.severity = none | |||
|
|
|||
| #Can reassign collections | |||
| dotnet_diagnostic.CA2227.severity = none | |||
|
|
|||
| # No need to mark CLSCompliant | |||
| dotnet_diagnostic.CA1014.severity = none | |||
There was a problem hiding this comment.
This isn't something we've been following so this suppresses the warnings
| @@ -552,95 +552,6 @@ await _classUnderTest | |||
| } | |||
| #endregion | |||
|
|
|||
| #region Cash Import | |||
There was a problem hiding this comment.
These are redundant now because we're no longer calling this method for this report - there's nothing to mock and the new test runs directly against the Dockerised db
| * with the total value of transactions for each rent group | ||
| * with summed totals across all rent groups | ||
| */ | ||
|
|
||
| [Fact] | ||
| public async void ShouldGetCashImportByDate() |
There was a problem hiding this comment.
Expanded this test to insert multiple records and ensure that they were being grouped and aggregated correctly
| @@ -63,5 +64,31 @@ public interface IDatabaseContext | |||
| Task<List<string[]>> GetItemisedTransactionsByYearAndTransactionTypeAsync(int year, string transactionType); | |||
| Task<List<string[]>> GetHousingBenefitAcademyByYear(int year); | |||
| Task<IList<string[]>> GetReportAccountBalance(DateTime reportDate, string rentGroup); | |||
|
|
|||
| public DbSet<BatchLog> BatchLogs { get; set; } | |||
There was a problem hiding this comment.
These weren't in the interface and so didn't allow access in the tests - added these for current and future convenience
adamtry
commented
Aug 8, 2024
| @@ -41,7 +41,7 @@ public async Task ShouldLoadHousingFilesAndReturnStepResponse() | |||
|
|
|||
| // Assert | |||
| result.Continue.Should().BeTrue(); | |||
| result.NextStepTime.Should().BeCloseTo(DateTime.Now.AddSeconds(_waitDuration)); | |||
| result.NextStepTime.Should().BeCloseTo(DateTime.Now.AddSeconds(_waitDuration), 500); | |||
There was a problem hiding this comment.
Was flaky on CircleCI
LBHCallumM
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for this process, rewritten in Entity Framework.
Runs on the EE Docker environment (make unit_db_ee)
See sproc code: https://github.com/LBHackney-IT/HFSDatabaseObjects/blob/880959d860c087cde6f946f16834e8f5b2416c0a/stored_procedures/usp_GetCashImportByDate.sql
What the stored procedure does is:
The test works the same with the original stored procedure SQL and the new entity framework code