Remove redundant LBHPACKAGESTOKEN

Historically we've published packages from our local machines, which requires a token
to authenticate with the GitHub Packages NuGet Registry. Now we use CI to publish
packages that write/publish token is no longer needed.

Hackney's NuGet packages are publicly readable, so a token isn't required to download
dependencies.

.github/workflows/publish.yml

@@ -9,8 +9,6 @@ jobs:
   calculate-version:
     name: Calculate Version
     runs-on: ubuntu-latest
-    env:
-      LBHPACKAGESTOKEN: ${{ secrets.LBHPACKAGESTOKEN }}
     outputs:
       version: ${{ steps.gitversion.outputs.nuGetVersionV2 }}
     steps:
@@ -35,8 +33,6 @@ jobs:
     name: Check code formatting
     runs-on: ubuntu-latest
     needs: calculate-version
-    env:
-      LBHPACKAGESTOKEN: ${{ secrets.LBHPACKAGESTOKEN }}
     steps:
       - name: Checkout
         uses: actions/checkout@v2
@@ -49,8 +45,6 @@ jobs:
     name: Build & Test
     runs-on: ubuntu-latest
     needs: calculate-version
-    env:
-      LBHPACKAGESTOKEN: ${{secrets.LBHPACKAGESTOKEN }}
     outputs:
       version: ${{ needs.calculate-version.outputs.version }}
     steps:
@@ -66,7 +60,6 @@ jobs:
     runs-on: ubuntu-latest
     needs: build-and-test
     env:
-      LBHPACKAGESTOKEN: ${{secrets.LBHPACKAGESTOKEN }}
       VERSION: ${{ needs.build-and-test.outputs.version }}
     steps:
       - name: Checkout

Hackney.Shared.HousingSearch.Tests/Dockerfile

@@ -3,8 +3,6 @@ FROM mcr.microsoft.com/dotnet/sdk:6.0
 # disable microsoft telematry
 ENV DOTNET_CLI_TELEMETRY_OPTOUT='true'
 
-ARG LBHPACKAGESTOKEN
-ENV LBHPACKAGESTOKEN=$LBHPACKAGESTOKEN
 WORKDIR /app
 
 # Copy csproj and restore as distinct layers

docker-compose.yml

@@ -6,5 +6,3 @@ services:
     build:
       context: .
       dockerfile: Hackney.Shared.HousingSearch.Tests/Dockerfile
-      args:
-        - LBHPACKAGESTOKEN=${LBHPACKAGESTOKEN}

nuget.config

@@ -6,11 +6,4 @@
     <add key="github-hackney" value="https://nuget.pkg.github.com/LBHackney-IT/index.json" />
   </packageSources>
 
-  <packageSourceCredentials>
-    <github-hackney>
-      <add key="Username" value="PublicToken" />
-      <add key="ClearTextPassword" value="%LBHPACKAGESTOKEN%" />
-    </github-hackney>
-  </packageSourceCredentials>
-
 </configuration>