Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket
TS-1406
Describe this PR
What is the problem we're trying to solve
Current
TempAccommodationOfficer
does not haveId
property. We'll be storing the officer details toPerson
table and need to be able to add the guid from the table to theTempAccommodationOfficer
object, so we can link the records together.What changes have we introduced
Id
property to theTempAccommodationOfficer
objectTempAccommodationInfo
andTempAccommodationOfficer
objects to use standard constructors rather than the .Create pattern used for other domain objects. (Please see item 4. on how the properties are now handled)TempAccommodationInfo
object had theQueryableTempAccommodationOfficer
entity object in it rather than the correctTempAccommodationOfficer
domain objectQueryableTempAccommodationInfo
andQueryableTempAccommodationOfficer
entities to domain objects. This is LBH standard pattern and replaces the constructor setup used in the previous implementationChecklist
Follow up actions after merging PR
N/A