Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-1406 add assigned ta officer #75

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

LBHTKarki
Copy link
Contributor

@LBHTKarki LBHTKarki commented Apr 29, 2024

Link to JIRA ticket

TS-1406

Describe this PR

What is the problem we're trying to solve

Current TempAccommodationOfficer does not have Id property. We'll be storing the officer details to Person table and need to be able to add the guid from the table to the TempAccommodationOfficer object, so we can link the records together.

What changes have we introduced

  1. Add Id property to the TempAccommodationOfficer object
  2. Refactor TempAccommodationInfo and TempAccommodationOfficer objects to use standard constructors rather than the .Create pattern used for other domain objects. (Please see item 4. on how the properties are now handled)
  3. Fix the issue where the TempAccommodationInfo object had the QueryableTempAccommodationOfficer entity object in it rather than the correct TempAccommodationOfficer domain object
  4. Introduce factories for converting TA related QueryableTempAccommodationInfo and QueryableTempAccommodationOfficer entities to domain objects. This is LBH standard pattern and replaces the constructor setup used in the previous implementation
  5. Add test coverage for the affected TA objects and factories
  6. Remove obsolete model tests
  7. [Unrelated] Update code owners to reflect the current structure

Checklist

  • Added end-to-end (i.e. integration) tests where necessary e.g to test complete functionality of a newly added feature
  • Added tests to cover all new production code
  • Added comments to the README or updated relevant documentation (add link to documentation), where necessary.
  • Checked all code for possible refactoring
  • Code pipeline builds correctly

Follow up actions after merging PR

N/A

@LBHTKarki LBHTKarki merged commit a9b66ef into main Apr 30, 2024
5 checks passed
@LBHTKarki LBHTKarki deleted the feature/ts-1406-add-assigned-ta-officer-id branch April 30, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants