TS-1610: Add new ApprovalStatus field to the AssetContract #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LBHJHeppinstall
approved these changes
Sep 6, 2024
adamtry
approved these changes
Sep 9, 2024
humulla
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket
https://hackney.atlassian.net/browse/TS-1610
Describe this PR
What is the problem we're trying to solve
BTA users want to be able to reset the contract approval status of an updated approved contract so that it can be submitted for reapproval. This calls for changing from a boolean value to an enum in the Contracts, to account for more than two possible statuses.
We haven't removed the
isApprovedflag yet so that the FE can continue to function until we introduce the new field there too.What changes have we introduced
New enum field.
Also this includes a fix by @notatiyyah on the docker setup for tests
Follow up actions after merging PR
Updates to the Listener and API.