Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-1537: Introducing ApprovalStatusReason #84

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

martapederiva
Copy link
Contributor

Link to JIRA ticket

https://hackney.atlassian.net/browse/TS-1537

Describe this PR

What is the problem we're trying to solve

BTA now needs to store the reason for which a Contract might be in PendingReapproval status.

What changes have we introduced

A new field in the appropriate places.

Follow up actions after merging PR

Update version on listener and API and changes to propagate and retrieve the new field.

@martapederiva martapederiva requested a review from a team as a code owner October 1, 2024 09:56
Copy link

@Duslerke Duslerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it confusing that there're 2 identical Domain level objects:

  1. Hackney.Shared.HousingSearch/Domain/Asset/Contract.cs
  2. Hackney.Shared.HousingSearch/Domain/Contract/Contract.cs

I see a Factory update that touches on one of them (1st one):

public Domain.Asset.Contract ToDomain(this QueryableAssetContract entity) {...}

But not there's no Factory update to the 2nd one. How come? Is it that the 2nd model isn't used, or is it that it doesn't have non-Domain layer equivalents?

@martapederiva
Copy link
Contributor Author

Is it that the 2nd model isn't used, or is it that it doesn't have non-Domain layer equivalents?

Yeah, the Contract/Contract is not really used. I reckon it was created for future use, we update it for coherence, likely useless but I don't want to find out now 😅 (Contracts API doesn't use the NuGet packages structure for its model)

@martapederiva martapederiva merged commit 044817b into main Oct 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants