TS-1614: Adding data about the end of an assetContract #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket
https://hackney.atlassian.net/browse/TS-1614
Describe this PR
What is the problem we're trying to solve
BTA users need a way to cancel invalid contracts (contracts opened in error) so that approval will no longer be required and no payment will be made to agent/landlord.
To do so, we need to see data about when and why a Contract was ended in the Asset information, as it will inform the decision about display a Contract for approval on BTA.
What changes have we introduced
Two properties for the Contract, wherever it appears on the Shared Package.
Follow up actions after merging PR
Updating the Listener and API