updates for OS 3.8 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnate
reviewed
Jul 25, 2024
| spec.add_dependency 'openstudio-extension', '~> 0.8.0' | ||
| spec.add_dependency 'openstudio-standards', '0.6.1' | ||
|
|
||
| spec.add_development_dependency 'bundler', '~> 2.4.10' | ||
| spec.add_development_dependency 'rake', '~> 13.0' |
There was a problem hiding this comment.
I think we can also remove the requirements for rake and bundler for the same reason as above: they are included with extension-gem. In fact, I think we should remove them to prevent accidentally trying to use an incorrect version.
vtnate
reviewed
Jul 25, 2024
| @@ -22,11 +22,14 @@ Gem::Specification.new do |spec| | |||
| spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } | |||
| spec.require_paths = ['lib'] | |||
|
|
|||
| spec.add_development_dependency 'bundler', '~> 2.1' | |||
| spec.required_ruby_version = '~> 3.2.2' | |||
There was a problem hiding this comment.
Suggested change
| spec.required_ruby_version = '~> 3.2.2' | |
| spec.required_ruby_version = '3.2.2' |
We support exactly Ruby v3.2.2 because os-extension-gem requires bundler==2.4.10 and that requires Ruby 3.2.2: https://stdgems.org/bundler/
|
@KaiyuSun Have you had a chance to work on this? We'd love to use this with OS 3.8. |
…exist problem in ruby 3
…pgrading to OS 3.8
|
Upgraded to OpenStudio 3.8 and Ruby 3.2.2. All measures have been tested through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KaiyuSun, I started this PR to help with the upgrades for OpenStudio 3.8 and Ruby 3.2.2. I didn't test any of the measures with OS 3.8 though. Let me know if you have any questions or run into issues with the measure updates!