Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(get_bias_addr): update and optimize bias address retrieval #493

Open
wants to merge 0 commits into
base: master
Choose a base branch
from

Conversation

h7ml
Copy link

@h7ml h7ml commented Jul 20, 2024

  • Add detailed Chinese comments to enhance code readability.
  • Improve error handling and user input validation.
  • Enhance the upload function with exception handling.
  • Apply consistent formatting and improve stylesheet handling.
  • Refactor and document GetBiasAddrControl and MyThread classes for better clarity.

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

🔀 变更说明 | Description of Change

针对于 #492https://mp.weixin.qq.com/s/mvae88fxG2BFte2TTGh1ZQ 添加get_bias_addr注释信息。避免造成误解

📝 补充信息 | Additional Information

@youncyb
Copy link

youncyb commented Jul 20, 2024

注释没注释到点上,你该注释一下这个类: BiasAddr,说明人家返回的是基址,而不是用户输入的手机号、名字等。

另外我认为这个pr没用,垂到一半发现锤错了,还让受害者负责。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants