Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional contribution analysis fixes #1430

Merged
merged 10 commits into from
Jan 16, 2025

Conversation

marc-vdm
Copy link
Member

@marc-vdm marc-vdm commented Jan 14, 2025

Changes

  • Various changes to CA wiki page to improve wording and update on following points
  • Subclass bw2analyzer.ContributionAnalysis to resolve bugs in original
  • Resolves: Range/Score negative contributions plot bug #1429
    • Results were normalized in a wrong way, representing the result wrongly.
  • Replaces Range with Score as default option in CA tabs
  • The Total line in contribution tables is replaced with Score, which better represents what this actually means.
  • Aggregate by categories for EF contributions is now actually resolved (EF Contribution Analysis > Aggregate by Categories broken #1385)
  • Improved sorting of contributions, which now favours entities with single high contributions more (mean square)
  • Add option to toggle score marker on/off

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@marc-vdm marc-vdm added the bug Issues/PRs related to bugs label Jan 14, 2025
@marc-vdm marc-vdm added this to the 2.11.1 milestone Jan 14, 2025
@marc-vdm marc-vdm requested a review from mrvisscher January 14, 2025 09:43
@coveralls
Copy link

coveralls commented Jan 14, 2025

Coverage Status

coverage: 53.087% (-0.2%) from 53.311%
when pulling ed7d705 on marc-vdm:ca_range_score_fix
into 1e02314 on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm changed the title fix wrong logic for range CA total additional contribution analysis fixes Jan 14, 2025
@marc-vdm marc-vdm merged commit eeb1685 into LCA-ActivityBrowser:main Jan 16, 2025
9 checks passed
@marc-vdm marc-vdm deleted the ca_range_score_fix branch January 16, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range/Score negative contributions plot bug
3 participants