-
Notifications
You must be signed in to change notification settings - Fork 59
Add 'cumulative percent' contribution analysis mode #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use this figure in the explanation of each adjustable item on the contribution page, I think it's better to keep the full width here.
See here for reference
https://github.com/LCA-ActivityBrowser/activity-browser/wiki/LCA-Results#manipulating-results
Adds 'cumulative percent' as a contribution analysis type in AB.
current types:
Relative
(refactored toPercent
): shows contributors of at least n%Top #
(refactored toNumber
): shows highest n contributorsNew type would show a
cumulative percentage
, all (sorted) contributions that together reach at least n%.e.g. in the process contributions example a cumulative percent set to 60% would only show steel production, with 80% it would show both steel production and electricity production.
This is relevant to add as e.g. the PEF regulations require the cumulative 80% contributors to be reported (chapter 6.3):
Issues:
Checklist
./activity_browser/docs/wiki
If you have write access (otherwise a maintainer will do this for you):
bug
,feature
,ui
,change
,documentation
,breaking
,ci
as they show up in the changelog.