Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaDataStore drops database when it's deleted from the project #1434

Merged

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Jan 16, 2025

The MetaDataStore will now check whether it's databases are still existing when a database is removed from the project.

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Jan 16, 2025
@mrvisscher mrvisscher added this to the 2.11.1 milestone Jan 16, 2025
@mrvisscher mrvisscher requested a review from marc-vdm January 16, 2025 13:13
@coveralls
Copy link

coveralls commented Jan 16, 2025

Coverage Status

coverage: 53.123% (+0.005%) from 53.118%
when pulling 62da4d3 on mrvisscher:metadata-sync-on-db-delete
into eeb1685 on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm merged commit 3c3b023 into LCA-ActivityBrowser:main Jan 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deleting database does not remove it from metadata
3 participants