Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commissioning fixes and results for the wavelength solution. #26

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Commissioning fixes and results for the wavelength solution. #26

merged 2 commits into from
Feb 26, 2024

Conversation

cmccully
Copy link
Contributor

@cmccully cmccully commented Nov 8, 2023

No description provided.

@cmccully cmccully requested a review from jchate6 November 8, 2023 16:36
@cmccully
Copy link
Contributor Author

cmccully commented Nov 8, 2023

Closes #17

@jchate6 jchate6 linked an issue Nov 13, 2023 that may be closed by this pull request
Test Wavelength Calibration effectiveness #17
Closed
4 tasks
jchate6
jchate6 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@jchate6 jchate6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I follow all of these changes, but nothing stands out as a problem. Should we be concerned with the failing 3.9 tests?

@cmccully
Copy link
Contributor Author

Those are timeout errors

I'm not sure I follow all of these changes, but nothing stands out as a problem. Should we be concerned with the failing 3.9 tests?

Those are timeouts unfortunately. I'm trying to fix those but may be beyond the scope of this pr.

@cmccully cmccully merged commit df2ee4e into main Feb 26, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchate6 jchate6 jchate6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Wavelength Calibration effectiveness
2 participants
@cmccully @jchate6