Commissioning extraction #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts pass now because I switched out the background fitting algorithm.
… which is a little weird that it works.
jchate6
requested changes
Mar 4, 2024
…s into commission-extraction
…making it easier to test. Increased the memory on the pods in hopes of getting rid of the flat stacking crashes.
jchate6
reviewed
Mar 21, 2024
jchate6
requested changes
Mar 21, 2024
There was a problem hiding this comment.
I'd really like some docs explaining the extraction process as a whole and summarizing the strategies we have used here. An explanation of and links to the various example jupyter notebooks seems really useful as well.
I clearly need to do some DB setup to properly use theExtraction jupyter notebook, but I'm not really sure what is required.
| @@ -32,6 +32,7 @@ def to_header(self): | |||
| header[f'POLYDOM{i + 1}'] = str(list(polynomial.domain)) | |||
| for j, coef in enumerate(polynomial.coef): | |||
| header[f'COEF{i + 1}_{j}'] = coef | |||
| header['EXTNAME'] = 'WAVELENGTHS' | |||
There was a problem hiding this comment.
What is this header keyword? Extension name? Does this have any other values? I'm not familiar with how this is used elsewhere.
There was a problem hiding this comment.
This is a FITS standard keyword that defines the name of an extension. It allows you to index hdus with a name rather than just an integer, e.g.
hdu_list = fits.open('foo.fits')
hdu_list['WAVELENGTHS'].data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks the fully commissioned extraction stage. This should mark the first fully usable production-ready version of the banzai-floyds pipeline.
The results of the commissioning tests are in the characterization_testing/Extraction jupyter notebook. Note that you have to run the wavelength calibration and fringe correction jupyter notebooks before the extraction notebook.
We perform optimal extraction ala Horne. Right now, I've removed all of the scaling of the telluric correction as the pipeline appears to better without. This probably should be revisited in the future.