Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes calendar bug #91

Merged
merged 3 commits into from
Nov 19, 2024
Merged

fixes calendar bug #91

merged 3 commits into from
Nov 19, 2024

Conversation

capetillo
Copy link
Collaborator

QUICK FIX: Calendar bug

Background:
Edward pointed out that the calendar rendered January 1970 on his end as the initial page. This was probably due to setting the max-date as new Date(currentSemesterEnd) rather than just having currentSemesterEnd which already is a date

On my end, after further inspection, I noticed that it would sometimes block out the initial page (November 2024)
Screenshot 2024-11-18 at 1 26 01 PM

@capetillo capetillo requested a review from zemogle November 18, 2024 21:26
@zemogle
Copy link
Contributor

zemogle commented Nov 19, 2024

I think I remember that browsers can interpret Date() differently and strings are not always reliable. I've pushed a solution to parse the date which hopefully addresses this. There is also a bug in the v-calendar library. I've put a workaround in for based on this comment

Could you have a look at this and if it is workable, please update the test.

@capetillo
Copy link
Collaborator Author

@zemogle updated the test, changes look great!

@capetillo capetillo merged commit 2364c63 into main Nov 19, 2024
1 check passed
@capetillo capetillo deleted the quick-fix/calendar branch November 19, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants