Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/back buttons #97

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Feature/back buttons #97

merged 3 commits into from
Nov 21, 2024

Conversation

capetillo
Copy link
Collaborator

FEATURE: Go back button in Beginner Scheduling

Background:
There was no back button so users could only refresh the page and go back all the way to the first step. Now, there's a back button that takes the user back to the previous step.

Implementation

  • Added two parts to this, nextStep and previousStep and they are helper functions that conditionally render.

VISUALS

Long screen recording of going back and forth

Screen.Recording.2024-11-20.at.3.14.13.PM.mov

Copy link

@jnation3406 jnation3406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the test failing, looks fine to me, but what is the loading when you select the date range in the video for?

@capetillo
Copy link
Collaborator Author

capetillo commented Nov 21, 2024

Other than the test failing, looks fine to me, but what is the loading when you select the date range in the video for?

@jnation3406 The test has been fixed! The loading is waiting for a response from whats up in the sky and it populates the object categories (i.e. star cluster, nebula, galaxy, supernova) with targets. So just waiting for the response

@capetillo capetillo merged commit da6cb78 into main Nov 21, 2024
1 check passed
@capetillo capetillo deleted the feature/back-buttons branch November 21, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants