Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aperture correction is added to 9999 in psfmag column #72

Open
abostroem opened this issue Dec 10, 2020 · 1 comment
Open

Aperture correction is added to 9999 in psfmag column #72

abostroem opened this issue Dec 10, 2020 · 1 comment
Labels

Comments

@abostroem
Copy link
Collaborator

The 10000.6195 in the PSFMAG column below look suspiciously like the aperture correction is being added to the psf instrumental magnitude in at least some cases:

lscloop.py -n 2016cok -e 20160528-20171231 -s checkdiff --show -f r
['rp', 'SDSS-R']
####################################################################################################
# IMAGE                                    OBJECT           FILTER           WCS             PSF           PSFMAG    APMAG       ZCAT          MAG      ABSCAT
cpt1m013-kb76-20160529-0115-e91.fl.diff	   AT2016cok	       rp	      0.0	cpt1m013-kb76-20160529-0115-e91.fl.diff.psf	10000.6195   9999.0	AT2016cok_sloan	   9999.0	        X
cpt1m013-kb76-20160529-0116-e91.fl.diff	   AT2016cok	       rp	      0.0	cpt1m013-kb76-20160529-0116-e91.fl.diff.psf	   9999.0	   9999.0	AT2016cok_sloan	   9999.0	        X
cpt1m010-kb70-20160530-0108-e91.fl.diff	   AT2016cok	       rp	      0.0	cpt1m010-kb70-20160530-0108-e91.fl.diff.psf	10000.6195   9999.0	AT2016cok_sloan	   9999.0	        X
cpt1m013-kb76-20160531-0122-e91.fl.diff	   AT2016cok	       rp	      0.0	cpt1m013-kb76-20160531-0122-e91.fl.diff.psf	  -6.6143	    -6.72	AT2016cok_sloan	  16.4428	        X
cpt1m013-kb76-20160531-0123-e91.fl.diff	   AT2016cok	       rp	      0.0	cpt1m013-kb76-20160531-0123-e91.fl.diff.psf	  -6.6523	   -6.891	AT2016cok_sloan	  16.4044	        X
cpt1m010-kb70-20160601-0132-e91.fl.diff	   SN2016cok	       rp	      0.0	cpt1m010-kb70-20160601-0132-e91.fl.diff.psf	10000.6195   9999.0	AT2016cok_sloan	   9999.0	        X
cpt1m013-kb76-20160605-0109-e91.fl.diff	   SN2016cok	       rp	      0.0	cpt1m013-kb76-20160605-0109-e91.fl.diff.psf	  -6.7803	   -6.911	AT2016cok_sloan	  16.2902	        X
cpt1m013-kb76-20160605-0110-e91.fl.diff	   SN2016cok	       rp	      0.0	cpt1m013-kb76-20160605-0110-e91.fl.diff.psf	   9999.0	   9999.0	AT2016cok_sloan	   9999.0	        X
cpt1m010-kb70-20160606-0099-e91.fl.diff	   SN2016cok	       rp	      0.0	cpt1m010-kb70-20160606-0099-e91.fl.diff.psf	   9999.0	   9999.0	AT2016cok_sloan	   9999.0	        X
@abostroem
Copy link
Collaborator Author

abostroem commented Dec 10, 2020

The following are locations in myloopdef.py that might be affected by this:

src/lsc/myloopdef.py:        if ggg[0]['psfmag'] == 9999 or ggg[0]['psfmag'] == 9999:
src/lsc/myloopdef.py:    elif stage == 'mag' and status >= 0 and ggg[0]['zcat'] != 'X' and ggg[0]['psfmag'] != 9999:
src/lsc/myloopdef.py:        if ggg[0]['mag'] == 9999:
src/lsc/myloopdef.py:        if ggg[0]['psfmag'] == 9999:
src/lsc/myloopdef.py:                        if lista['mag'][i] != 9999.0:
src/lsc/myloopdef.py:                        if _mag == 9999.0:
src/lsc/myloopdef.py:                            if lista['mag'][i] != 9999.0:
src/lsc/myloopdef.py:                        elif _mag != 9999.0:
src/lsc/myloopdef.py:                        if lista['psfmag'][i] != 9999.0:
src/lsc/myloopdef.py:                        if _psfmag == 9999.0:
src/lsc/myloopdef.py:                            if lista['psfmag'][i] != 9999.0:
src/lsc/myloopdef.py:                        elif _psfmag != 9999.0:
src/lsc/myloopdef.py:                        if lista['mag'][i] != 9999.0:
src/lsc/myloopdef.py:                        if _apmag == 9999.0:
src/lsc/myloopdef.py:                            if lista['apmag'][i] != 9999.0:
src/lsc/myloopdef.py:                        elif _apmag != 9999.0:

@abostroem abostroem added the bug label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant