-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ldmx-sw to be able to read MG5 inputs #1521
Comments
I generated a MG5 library using v5.0 of dark-brem-lib-gen.
The library generated has the correct structure. One directory with the LHE files within it. Then I ran the config from the signal validation sample.
which replicates the issue from the CI.
Luckily for me, past Tom figured that library parsing would be annoying and wrote the |
I'm guessing the LHE parser, which made some assumptions about the input LHE files, had those assumptions broken when we switched to MG5. |
Found it. The new MG model uses the PDG ID 1023 for the dark photon but we assume the PDG ID here is 622. There are two solutions:
I prefer option (1) since the PDG 1023 conforms with the PDG ID numbering standards and I know where to fix it. ldmx-sw/SimCore/src/SimCore/APrimePhysics.cxx Line 111 in 45ee57d
And actually, the Adding mySim.dark_brem.model.aprime_lhe_id = 1023 to the config then allows it to run normally! 🎉 |
That's what I guessed to in #1520 And I agree option 1) is to go. |
The nuclei IDs are ignored when parsing in G4DarkBreM. We just look for the target Z by scanning the file for the line with Certainly, if we want our Geant4 PDG IDs to match the IDs in the LHE, then we need more C++ changes. Specifically, in how we define the ldmx-sw/SimCore/src/SimCore/Generators/LHEPrimaryGenerator.cxx Lines 53 to 57 in 45ee57d
But I think this fix is only necessary because the nuclei was not conforming to the PDG ID standards. I think Geant4 will be able to deduce the correct nuclei from these IDs (untested). |
Is your feature request related to a problem? Please describe.
We moved the LHE production to MG5 in LDMX-Software/dark-brem-lib-gen#19
Describe the solution you'd like
Now next step is to change ldmx-sw to be able to read those LHE files
Describe alternatives you've considered
Keep using MG4 files
Additional context
Follow-up to #1520
The text was updated successfully, but these errors were encountered: