-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update default LHE ID for A' to be 1023 #1525
update default LHE ID for A' to be 1023 #1525
Conversation
This update then makes the default configuration of the dark brem model (from our point of view) align with the libraries that are produced by v5.0 of dark-brem-lib-gen. Users can still use earlier versions of dark-brem-lib-gen, but then they will need to change their configuration script to look for the old LHE ID 622 rather than the new one. ```python mySim.dark_brem.model.aprime_lhe_id = 622 ``` This change *does not* alter the PDG ID of the dark photon within our simulation. It will still have the PDG ID of 622 according to Geant4 and the output SimParticle.
Annoyingly (and why we didn't notice this before), the signal fails to generate any events but then that validation job completes "successfully". I can confirm that the exception that was observed in #1521 is observed here.
|
now that the default A' LHE ID is set to the one used by the MG5 model, updating the CI tests to use the MG5 model should work.
I'd say we should wait a little bit with merging this into the release, and have a patch before with v4.6, and then maybe in the next patch we should put this in |
The PR Validation run from after I marked this as Ready for Review did have the signal sample fully generated. The diff is very large because the current gold has no events in it due to this bug, so do not go to that action's page unless you can wait for the large page to load. Dropping this back to draft so we can re-run validation with an updated patch and compare MG5 to MG4 more directly. |
@tomeichlersmith did you rebase this? |
I have not. I don't know why the rebase was necessary for you, we specifically copy the gold from trunk so it should only matter when the workflow is triggered. ldmx-sw/.github/workflows/pr_validation.yml Lines 37 to 39 in 4b012fb
|
Hmmm interesting, I'm quite confused about the other PR then, but ok sounds good! |
This update then makes the default configuration of the dark brem model (from our point of view) align with the libraries that are produced by v5.0 of dark-brem-lib-gen.
Users can still use earlier versions of dark-brem-lib-gen, but then they will need to change their configuration script to look for the old LHE ID 622 rather than the new one.
This change does not alter the PDG ID of the dark photon within our simulation. It will still have the PDG ID of 622 according to Geant4 and the output SimParticle.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This resolves #1521
Check List
When opening this PR as a draft, the signal validation sample action will fail to run because it will be looking for ID 1023 in v4 dark brem libraries where the ID is 622. I'll then edit the CI to use v5 dark brem libraries and then they will succeed when I mark this PR as ready for review.