First version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
survived
force-pushed
the
first-version
branch
from
6aabd80 to
4638aef
Compare
maurges
reviewed
Feb 29, 2024
maurges
reviewed
Feb 29, 2024
maurges
reviewed
Mar 8, 2024
maurges
reviewed
Mar 8, 2024
|
The math seems to check out. Now I only have tests to look at |
|
@maurges do you want me to move tests into a dedicated PR? I'm blocked cz I can't progress on frost implementation. I need to add bitcoin support, that will change the impl a bit but shouldn't change the tests. |
|
Nah, I think I'll rather review them later and raise separate issues |
maurges
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not in the scope of this PR:
no_stdsupportSpecs: https://www.ietf.org/archive/id/draft-irtf-cfrg-frost-15.html