-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve simulation UX #14
Conversation
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One part of me wants to say that we should keep the old api, on the other hand I'm not going to use it anywhere.
One nitpick is that I'd prefer using "simulation" instead of "sim"
Signed-off-by: Denis Varlakov <[email protected]>
How do we improve UX and evolve the lib if we commit to keep old api? 😃 |
I also thought about it, though writing "simulation" wasn't an issue when I was updating all the dependent lib... I think I'll go ahead and use shorter name |
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Too soon! @maurges Clippy suddenly started complaining on unmodified part of the library |
That's a large PR... |
Writing tests for MPC protocols involves copy-pasting the same boilerplate over and over again. This PR improves ergonomics by moving the most common logic into the lib.
You can see how it improves the tests in LFDT-Lockness/cggmp21#120, specifically in 81191c0:
futures::future::try_join_all
.expect_eq()
)Other changes:
std
feature. All errors implementcore::error::Error
trait.