fix: fix tests

LLCFreedom-Space · Apr 30, 2024 · 05cdf0d · 05cdf0d
1 parent 6f82c28
commit 05cdf0d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/Sources/HealthChecks/MongoHealthChecks/MongoRequest.swift b/Sources/HealthChecks/MongoHealthChecks/MongoRequest.swift
@@ -42,6 +42,8 @@ public struct MongoRequest: MongoRequestSendable {
     /// - Returns: `String`
     public func getConnection(by url: String) async throws -> String {
         app.mongoCluster = try? await MongoCluster(connectingTo: ConnectionSettings(url))
-        return "\(app.mongoCluster?.connectionState ?? .disconnected)"
+        let connection = "\(app.mongoCluster?.connectionState ?? .disconnected)"
+        await app.mongoCluster?.disconnect()
+        return connection
     }
 }
diff --git a/Sources/HealthChecks/PostgresHealthChecks/PostgresHealthChecks.swift b/Sources/HealthChecks/PostgresHealthChecks/PostgresHealthChecks.swift
@@ -49,7 +49,6 @@ public struct PostgresHealthChecks: PostgresHealthChecksProtocol {
         let result = HealthCheckItem(
             componentId: app.psqlId,
             componentType: .datastore,
-            observedValue: connectionDescription.contains("active") ? 1 : nil,
             status: connectionDescription.contains("active") ? .pass : .fail,
             time: app.dateTimeISOFormat.string(from: Date()),
             output: !connectionDescription.contains("active") ? connectionDescription : nil,

diff --git a/Tests/HealthChecksTests/PostgresHealthChecksTests.swift b/Tests/HealthChecksTests/PostgresHealthChecksTests.swift
@@ -38,7 +38,6 @@ final class PostgresHealthChecksTests: XCTestCase {
         app.psqlHealthChecks = PostgresHealthChecks(app: app, postgresDatabase: "test")
         let result = await app.psqlHealthChecks?.connection()
         XCTAssertEqual(result?.componentType, .datastore)
-        XCTAssertEqual(result?.observedValue, 1)
         XCTAssertEqual(result?.status, .pass)
         XCTAssertNil(result?.affectedEndpoints)
         XCTAssertNil(result?.output)
@@ -82,7 +81,6 @@ final class PostgresHealthChecksTests: XCTestCase {
         let result = await app.psqlHealthChecks?.check(for: [MeasurementType.responseTime, MeasurementType.connections])
         let psqlConnections = result?["\(ComponentName.postgresql):\(MeasurementType.connections)"]
         XCTAssertEqual(psqlConnections?.componentType, .datastore)
-        XCTAssertEqual(psqlConnections?.observedValue, 1)
         XCTAssertEqual(psqlConnections?.status, .pass)
         XCTAssertNil(psqlConnections?.affectedEndpoints)
         XCTAssertNil(psqlConnections?.output)