Get the handle from dlopen and not from debug infos #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkino
commented
Feb 11, 2024
| @@ -161,7 +162,8 @@ static void *dlsym_wrapper(void *handle, const char *symbol_name) { | |||
| struct link_map *lib = gotchas_dlsym_rtld_next_lookup( | |||
| symbol_name, __builtin_return_address(0)); | |||
| if (lib) { | |||
| void *symbol = orig_dlsym(lib, symbol_name); | |||
| void *handle = orig_dlopen(lib->l_name, RTLD_NOW); | |||
There was a problem hiding this comment.
I have a doubt between RTLD_NOW and RTLD_LAZY
hariharan-devarajan
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #142
You should look twice and understand it twice before merge (we are out of my competences).
There is 2 different
link_map, one is internal and seen in the API only asvoid*returned bydlopen()and used as first argument bydlsym().The other one is public but is used for debugging purpose.