Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for 146 #147

Closed
wants to merge 2 commits into from
Closed

Bugfix for 146 #147

wants to merge 2 commits into from

Conversation

hariharan-devarajan
Copy link
Member

We need a variable to track if we updated the library's symbol table. If not we should not use them in dlsym. #146

@bertwesarg can u see if this works.

I think, what the app should do is wrap after the library is loaded.

We need a variable to track if we updated the library's symbol table. If not we should not use them in dlsym.
@hariharan-devarajan hariharan-devarajan marked this pull request as draft April 18, 2024 21:30
@bertwesarg
Copy link
Contributor

This works with my examples, including the second when removing the filtering. Will test this with the real tool tomorrow. Thanks.

I think, what the app should do is wrap after the library is loaded.

I think I cannot control this. We do the wrapping in a constructor before main, whether the app is actually using OpenCL is not known at this point, and waiting for the first use is not possible without wrapping in place.

@hariharan-devarajan
Copy link
Member Author

I am not still satisfied with this. I think there is some code which already does this. I will dig into it more :)

@hariharan-devarajan
Copy link
Member Author

I will try a second approach and see which I like the most. Will share once I have something .

@hariharan-devarajan
Copy link
Member Author

Closing this PR as #148 is a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants